refactor: amplify-category-notifications aws sdk v3 migration #14271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCat567
reviewed
Oct 6, 2025
packages/amplify-category-notifications/src/__tests__/channel-apns.test.ts
Show resolved
Hide resolved
dgandhi62
force-pushed
the
category-notifications/sdk-v3-migration
branch
2 times, most recently
from
9e2c76c to
712d1a3
Compare
dgandhi62
force-pushed
the
category-notifications/sdk-v3-migration
branch
from
712d1a3 to
58e77c8
Compare
…n stacks are stuck - Add failure predicate to treat _IN_PROGRESS states as failed after timeout - Reduce timeout to 15 minutes to fail faster on stuck operations - Prevents Jest worker processes from being killed due to hanging deletions
ShadowCat567
reviewed
Oct 8, 2025
packages/amplify-category-notifications/src/__tests__/channel-apns.test.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-notifications/src/__tests__/channel-apns.test.ts
Outdated
Show resolved
Hide resolved
packages/amplify-category-notifications/src/__tests__/channel-fcm.test.ts
Show resolved
Hide resolved
- Add sendEof() to In-App Messaging case to prevent hanging processes - Add notifications-analytics-compatibility-in-app-2.test.ts to RUN_SOLO to prevent Jest worker memory issues
dgandhi62
force-pushed
the
category-notifications/sdk-v3-migration
branch
from
6e7eed1 to
ae486c9
Compare
dgandhi62
force-pushed
the
category-notifications/sdk-v3-migration
branch
from
ff7e800 to
53e973b
Compare
dgandhi62
force-pushed
the
category-notifications/sdk-v3-migration
branch
from
1ece5b1 to
c9528db
Compare
dgandhi62
force-pushed
the
category-notifications/sdk-v3-migration
branch
from
464ad5f to
7499c10
Compare
packages/amplify-category-notifications/src/__tests__/channel-fcm.test.ts
Show resolved
Hide resolved
ShadowCat567
previously approved these changes
Oct 17, 2025
ShadowCat567
approved these changes
Oct 21, 2025
ShadowCat567
added a commit
that referenced
this pull request
Oct 21, 2025
…#14271)" (#14285) This reverts commit 2d0c169. Co-authored-by: aws-amplify-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor: start notifications category migration
refactor: migrate pinpoint-helper to sdk v3
refactor: migrate channel handlers to sdk v3
refactor: migrate auth-helper to sdk v3
refactor: update test mocks for sdk v3
refactor: migrate cli logout command to sdk v3
refactor: migrate e2e-core pinpoint utils to sdk v3
fix: update package dependencies
fix: correct client import names
fix: yarn lock updates
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.